fix: restrict view-mode click activation to content column (Closes #221)#230
Merged
Conversation
Clicks in the wide horizontal margins around the centered view-mode column previously fell through to whichever block they shared a row with, causing accidental checklist toggles and embed opens when the user was just clicking around to focus the terminal or select text. Adds viewContentXRange() as the single source of truth for the [leftPad, leftPad+contentWidth) bounds and uses it in both the click and hover handlers so visual feedback matches activation. Hover is narrowed too, so the highlight no longer suggests clickability in margins where clicks won't fire. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewContentXRange()helper as the single source of truth for the centered view-mode column bounds.[leftPad, leftPad+contentWidth)so margin clicks no longer toggle checklists or open embeds.Test plan
go test ./...— all greengo vet ./...— cleanTestMouseClickInLeftMarginDoesNotToggle,TestMouseClickInRightMarginDoesNotToggle🤖 Generated with Claude Code